remove warning from nbdev as pkg_resources is already deprecated#1522
Closed
kurianbenoy-sarvam wants to merge 2 commits intoAnswerDotAI:mainfrom
Closed
remove warning from nbdev as pkg_resources is already deprecated#1522kurianbenoy-sarvam wants to merge 2 commits intoAnswerDotAI:mainfrom
kurianbenoy-sarvam wants to merge 2 commits intoAnswerDotAI:mainfrom
Conversation
kurianbenoy-sarvam
changed the title
kurianbenoy-sarvam
changed the title
jph00
reviewed
Jun 21, 2025
nbdev/doclinks.py
Outdated
| if incl_libs is not None and o.dist.key not in incl_libs: continue | ||
| try: entries[o.name] = _qual_syms(o.resolve()) | ||
| eps = importlib.metadata.entry_points() | ||
| for o in eps.select(group='nbdev') if hasattr(eps, 'select') else eps.get('nbdev', []): |
Contributor
There was a problem hiding this comment.
This doesn't appear to be valid python syntax. Be sure to carefully test all code you add before you put a PR in! I'll take a look at fixing this issue on my end.
Author
There was a problem hiding this comment.
It seems to be valid python code.
Also all the tests where passing when I tried out.
Contributor
There was a problem hiding this comment.
You can see the error in the notebook.
Author
There was a problem hiding this comment.
Are you expecting me to run this in notebook?
Author
There was a problem hiding this comment.
- I ran this notebook end to end and still did not face any issues.
Author
|
|
Contributor
|
We fixed this locally now - thanks for your input! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jph00 I have constantly getting this warning in my nbdev projects for the last few months. Today is the day to fix it.